London | 26-ITP-May | Chun Yan Wong | Sprint 1 | Form Controls#1316
Open
cywong-dev wants to merge 10 commits into
Open
London | 26-ITP-May | Chun Yan Wong | Sprint 1 | Form Controls#1316cywong-dev wants to merge 10 commits into
cywong-dev wants to merge 10 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cywong-dev
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
cywong-dev
changed the title
cywong-dev
added
the
Needs Review
Luro91
added
the
Review in progress
Luro91
reviewed
May 20, 2026
Luro91
added
Reviewed
cywong-dev
added
Needs Review
Luro91
added
Reviewed
cywong-dev
added
Needs Review
This reverts commit 3092b42.
Luro91
reviewed
May 25, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
A note on commit messages. It's hard to know for me what happens in a commit if the message is not descriptive. A commit should describe what changed in the code. It's also good practice to split commits into logical blocks (for example for each task or each review comment). This makes it easier to understand and additionally the commits could also be undone more easily if needed.
I like this article about commit messages: https://chris.beams.io/git-commit
Comment on lines
+22
to
+29
| background-color: transparent; | ||
| } | ||
|
|
||
| .customer-form button { | ||
| width: 100%; | ||
| padding: 10px; | ||
| background-color: #0056b3; /* darker blue */ | ||
| color: #ffffff; |
There was a problem hiding this comment.
It's good practice to use indentation for the stylesheet as well. It makes it easier to read the code.
Luro91
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Display the form for the requirement with validation and display required
Questions
Nil